linux-kernel - Re: [PATCH] vt_ioctl.c: fix compile error with pm_set_vt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6392794.F5gNpf4v9p@wuerfel>
Date:	Tue, 06 Sep 2011 21:29:18 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	"gregkh@...e.de" <gregkh@...e.de>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"art@...ed.ca" <art@...ed.ca>, "jslaby@...e.cz" <jslaby@...e.cz>
Subject: Re: [PATCH] vt_ioctl.c: fix compile error with pm_set_vt_switch()

On Tuesday 06 September 2011 13:26:12 H Hartley Sweeten wrote:
> Your patch below does appear to fix the problem.
> 
> Tested-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> 
> 
> There is still a bit of #if ugliness with the pm_{prepare,restore}_console.
> 
> The source file kernel/power/console.c is compiled when CONFIG_PM_SLEEP is
> enabled.  But that file ends up empty if CONFIG_VT and CONFIG_VT_CONSOLE are
> not defined.
> 
> I wonder if it would be cleaner to make a new entry in kernel/power/Kconfig:
> 
> config PM_SLEEP_CONSOLE
>         def_bool y
>         depends on PM_SLEEP && VT && VT_CONSOLE
> 
> Then use that config option in the Makefile and in suspend.h.

Yes, that would be cleaner. I would probably move it to drivers/tty/vt
in the same step and name the option VT_CONSOLE_SLEEP.

Do you want to send a patch?

Thanks for testing!

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/