linux-kernel - RE: [PATCH 2/5] mce: mask out undefined bits from MCi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <987664A83D2D224EAE907B061CE93D5301EA8F97DC@orsmsx505.amr.corp.intel.com>
Date:	Tue, 6 Sep 2011 13:15:46 -0700
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Chen Gong <gong.chen@...ux.intel.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>, Borislav Petkov <bp@...64.org>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
Subject: RE: [PATCH 2/5] mce: mask out undefined bits from MCi_ADDR

>> +		if (mce_ser&&  (m->status&  MCI_STATUS_MISCV)) {
>> +			u8 shift = m->misc&  0x1f;
>
> According to SDM, here it should be "m->misc & 0x3f"

Correct. You, or somebody pointed this out before ... and I managed to
drop the fix while merging & rebasing ... will try to get it applied
this time.

Thanks

-Tony