linux-kernel - Re: [PATCH 05/12] staging: mei: adding watchdog ping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110906234811.GA15235@kroah.com>
Date:	Tue, 6 Sep 2011 16:48:11 -0700
From:	Greg KH <greg@...ah.com>
To:	Dan Carpenter <error27@...il.com>
Cc:	Oren Weil <oren.jer.weil@...el.com>, devel@...verdev.osuosl.org,
	linux-watchdog@...r.kernel.org, gregkh@...e.de,
	linux-kernel@...r.kernel.org, tomas.winkler@...el.com,
	alan@...ux.intel.com
Subject: Re: [PATCH 05/12] staging: mei: adding watchdog ping

On Wed, Aug 31, 2011 at 07:52:24PM +0300, Dan Carpenter wrote:
> On Wed, Aug 31, 2011 at 04:42:41PM +0300, Oren Weil wrote:
> > +static int mei_wd_ops_ping(struct watchdog_device *wd_dev)
> > +{
> > +	int ret = 0;
> > +	struct mei_device *dev;
> > +	dev = pci_get_drvdata(mei_device);
> > +
> > +	if (!dev)
> > +		return -ENODEV;
> > +
> > +	mutex_lock(&dev->device_lock);
> > +
> > +	if (dev->wd_cl.state != MEI_FILE_CONNECTED) {
> > +		dev_dbg(&dev->pdev->dev, "wd is not connected.\n");
> > +		ret = -ENODEV;
> > +		goto end;
> > +	}
> > +
> > +	/* Check if we can send the ping to HW*/
> > +	if (dev->mei_host_buffer_is_empty &&
> > +		mei_flow_ctrl_creds(dev, &dev->wd_cl) > 0) {
> > +			dev->mei_host_buffer_is_empty = false;
>         ^^^^^^^^^^^^^^^^
> 
> This is a two tab indent.  Don't do that.

Yeah, that's odd.

Oren, care to redo this patch and resend the whole series?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/