linux-kernel - Re: [PATCH] Staging: comedi: Removed unnecessary "extern" from do_become

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110906235846.GA10622@kroah.com>
Date:	Tue, 6 Sep 2011 16:58:46 -0700
From:	Greg KH <greg@...ah.com>
To:	Johannes Thumshirn <morbidrsa@...glemail.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: Removed unnecessary "extern" from
 do_become_nonbusy()

On Sun, Sep 04, 2011 at 05:36:29PM +0200, Johannes Thumshirn wrote:
> Removed unnecessary "extern" label from do_become_nonbusy() function to make
> checkpatch.pl happy
> 
> Signed-off-by: Johannes Thumshirn <morbidrsa@...glemail.com>
> ---
>  drivers/staging/comedi/comedi_fops.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index e90e3cc..c46db8f 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -101,8 +101,7 @@ static int do_insn_ioctl(struct comedi_device *dev,
>  static int do_poll_ioctl(struct comedi_device *dev, unsigned int subd,
>  			 void *file);
>  
> -extern void do_become_nonbusy(struct comedi_device *dev,
> -			      struct comedi_subdevice *s);
> +void do_become_nonbusy(struct comedi_device *dev, struct comedi_subdevice *s);

This patch does not apply, what tree did you make it against?

Please try it against the latest linux-next tree and resend it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/