linux-kernel - Re: [PATCH v6 08/10] crc32-add-slicing-by-8.diff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <OFCE19A3DB.816B06DF-ONC1257904.002E9D19-C1257904.002EC071@transmode.se>
Date:	Wed, 7 Sep 2011 10:30:39 +0200
From:	Joakim Tjernlund <joakim.tjernlund@...nsmode.se>
To:	unlisted-recipients:; (no To-header on input)
Cc:	Bob Pearson <rpearson@...temfabricworks.com>,
	akpm@...ux-foundation.org, fzago@...temfabricworks.com,
	George Spelvin <linux@...izon.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 08/10] crc32-add-slicing-by-8.diff

Joakim Tjernlund/Transmode wrote on 2011/09/07 09:31:18:
> > +# if CRC_LE_BITS == 32
> >     rem_len = len & 3;
> > -   /* load data 32 bits wide, xor data 32 bits wide. */
> >     len = len >> 2;
> > +# else
> > +   rem_len = len & 7;
> > +   len = len >> 3;
>
> I still fail to see why this is needed. You still do 32 bit loads so this
> only makes the code uglier, harder to maintain and makes small unaligned crc bufs
> slower.

Sorry, misread this part. Ignore it.

 Jocke

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/