linux-kernel - Re: [PATCH 3.1-rc1] ARM: entry: fix wrong parameter used in do_thumb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 Sep 2011 13:10:08 +0200
From:	Janusz Krzysztofik <jkrzyszt@....icnet.pl>
To:	Russell King <linux@....linux.org.uk>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3.1-rc1] ARM: entry: fix wrong parameter used in do_thumb_abort

Any plans to fix this regression before the rc cycle is over, or at 
least explain why it won't be fixed?

Any special requirements as to the process of submitting bug fixes 
against arch/arm common bits?

Thanks,
Janusz

On Wed, 24 Aug 2011 at 13:07:20, Janusz Krzysztofik wrote:
> Commit be020f8618ca, "ARM: entry: abort-macro: specify registers to
> be used for macros", while replacing register numbers with macro
> parameter names, mismatched the parameter used for r1. For me, this
> resulted in user space, built for EABI with -march=armv4t
> -mtune=arm920t -mthumb- interwork -mthumb, broken on my OMAP1510
> based Amstrad Delta (old ABI with -mno-thumb still worked for me
> though).
> 
> Fix this by using correct parameter, fsr, instead of mismatched psr,
> used by callers for another purpose.
> 
> Tested on OMAP1510 Amstrad Delta
> 
> Signed-off-by: Janusz Krzysztofik <jkrzyszt@....icnet.pl>
> ---
>  arch/arm/mm/abort-macro.S |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mm/abort-macro.S b/arch/arm/mm/abort-macro.S
> index 52162d5..2cbf68e 100644
> --- a/arch/arm/mm/abort-macro.S
> +++ b/arch/arm/mm/abort-macro.S
> @@ -17,7 +17,7 @@
>  	cmp	\tmp, # 0x5600			@ Is it ldrsb?
>  	orreq	\tmp, \tmp, #1 << 11		@ Set L-bit if yes
>  	tst	\tmp, #1 << 11			@ L = 0 -> write
> -	orreq	\psr, \psr, #1 << 11		@ yes.
> +	orreq	\fsr, \fsr, #1 << 11		@ yes.
>  	b	do_DataAbort
>  not_thumb:
>  	.endm
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/