linux-kernel - RE: [PATCH v6 05/10] crc32-misc-cleanup.diff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF2CB0F7C7.DAD4E211-ONC1257904.00299258-C1257904.002A1865@transmode.se>
Date:	Wed, 7 Sep 2011 09:39:47 +0200
From:	Joakim Tjernlund <joakim.tjernlund@...nsmode.se>
To:	"Bob Pearson" <rpearson@...temfabricworks.com>
Cc:	"'Andrew Morton'" <akpm@...ux-foundation.org>,
	fzago@...temfabricworks.com,
	"'George Spelvin'" <linux@...izon.com>,
	linux-kernel@...r.kernel.org,
	"'Stephen Rothwell'" <sfr@...b.auug.org.au>
Subject: RE: [PATCH v6 05/10] crc32-misc-cleanup.diff

"Bob Pearson" <rpearson@...temfabricworks.com> wrote on 2011/09/06 22:18:35:
>
> >
> > Yup.  lib-crc-add-slice-by-8-algorithm-to-crc32c.patch is dead meat.  I
> > sometimes keep things like that around to get them a bit of testing
> > while reminding myself that there's an open issue to track.
>
> I thought I was getting close until recently someone sent out a patch set
> for crc32c.c, the other 32 bit CRC in common use, based on an earlier
> version of the changes we have been working on for crc32.c. This has brought
> in other interested parties and created a bit of duplicated code. I am at a
> loss as to the best way to proceed. Personally I would like to see this
> change go upstream and then let the rest of the world figure out how to best
> merge things.

The crc32c code should be moved to lib and integrated into crc32.c. Then you get
all the optimizations for free. It think the new crypto crc32c code should just
be nacked.

 Jocke

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/