linux-kernel - Re: [PATCH 2/3] nbd: add support for feature negotiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAECXXi6NO1gvmREr_31ve-k67fsirqerdm7=ZX0tYqx+Yj52Sw@mail.gmail.com>
Date:	Wed, 7 Sep 2011 17:54:01 -0400
From:	Paul Clements <paul.clements@...sios.com>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
	nbd-general@...ts.sourceforge.net
Subject: Re: [PATCH 2/3] nbd: add support for feature negotiation

On Wed, Sep 7, 2011 at 1:52 PM, Paolo Bonzini <pbonzini@...hat.com> wrote:
> On 09/07/2011 06:30 PM, Paul Clements wrote:
>>
>> Could you name this as NBD_SET_FLAGS, as that's more consistent with
>> what it's really doing?
>
> I named it differently intentionally, actually, because it should not use
> the flags field from the network protocol as is.  Also, "features" sounds
> more like something that is optional, while unrecognized "flags" should
> probably cause a failure.

Alright, I can buy that argument -- I don't feel that strongly about it...

This looks good to me, then.

--
Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/