linux-kernel - RFC : squashfs : devblksize set to 4KB instread of BLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 8 Sep 2011 09:26:37 +0900
From:	NamJae Jeon <linkinjeon@...il.com>
To:	phillip@...gher.demon.co.uk, squashfs-devel@...ts.sourceforge.net
Cc:	linux-kernel@...r.kernel.org
Subject: RFC : squashfs : devblksize set to 4KB instread of BLK_SIZE(1KB).

Currently, devblksize is set to 1KB in squashfs like below code.

#define BLOCK_SIZE_BITS 10
#define BLOCK_SIZE (1<<BLOCK_SIZE_BITS)

msblk->devblksize = sb_min_blocksize(sb, BLOCK_SIZE);
-> msblk->devblksize = sb_min_blocksize(sb, PAGE_SIZE); or
->#define SQUASHFS_DEVBLK_SIZE 4096
-> msblk->devblksize = sb_min_blocksize(sb, SQUASHFS_DEVBLK_SIZE);

If devblksize is set by NAND page size before, I think that it is
changed to optimal vaule with increasing physical page size of NAND.

So I suggest that devblksize is set to 4KB, it is suitable for
physical page size of NAND(Onenand,flexOnenand 4KB) and minimal
compressed size.

We will gain improved performance(~20%) and stop reading inefficiently
several time by page alignment.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/