linux-kernel - Re: [PATCH] dmaengine: add CSR SiRFprimaII DMAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABb+yY26KytnyPiQ7BaMsqjKAF9px9XBXixZiJZL1EYZKBQVow@mail.gmail.com>
Date:	Thu, 8 Sep 2011 13:19:00 +0530
From:	Jassi Brar <jassisinghbrar@...il.com>
To:	Barry Song <21cnbao@...il.com>
Cc:	"Koul, Vinod" <vinod.koul@...el.com>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"Williams, Dan J" <dan.j.williams@...el.com>,
	"arnd@...db.de" <arnd@...db.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"workgroup.linux@....com" <workgroup.linux@....com>,
	"rongjun.ying@....com" <rongjun.ying@....com>,
	"Baohua.Song@....com" <Baohua.Song@....com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] dmaengine: add CSR SiRFprimaII DMAC driver

On Thu, Sep 8, 2011 at 12:06 PM, Barry Song <21cnbao@...il.com> wrote:
> 2011/9/8 Jassi Brar <jassisinghbrar@...il.com>:
>> According to figures, {xlen > width} is to be set _only_ when a transfer
>> is divided into _exactly_ two chunks separated by gap _exactly_
>> equal to length of the second chunk (an extremely rare case).
>
> Sorry i didn't list related full information in datasheet in my early reply.
> we don't have the case of xlen > dma_width.
Then the dmac driver becomes even simpler.
Accept strictly 'rectangular' requests and reject every other.


>> Anyways, every case can be easily expressed using the generic api
>> I proposed. See 'struct xfer_template' in https://lkml.org/lkml/2011/8/12/128
>
> i think it is the interleaved DMA case and there is a
> inter-chunk-gap(ICG) between every chunk while dma_width > xlen,
> then your new generic API can definitely cover this case.
>
Yup, it does. Thanks for confirming.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/