linux-kernel - Re: [PATCH 31/62] driver/char: irq: Remove IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 08 Sep 2011 12:55:41 +0200
From:	Clemens Ladisch <clemens@...isch.de>
To:	Yong Zhang <yong.zhang0@...il.com>
CC:	linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...e.hu,
	Corey Minyard <minyard@....org>,
	Mark Gross <mark.gross@...el.com>,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
	Arnd Bergmann <arnd@...db.de>,
	openipmi-developer@...ts.sourceforge.net
Subject: Re: [PATCH 31/62] driver/char: irq: Remove IRQF_DISABLED

Yong Zhang wrote:
> This flag is a NOOP and can be removed now.
> 
> Signed-off-by: Yong Zhang <yong.zhang0@...il.com>
> ---
>  drivers/char/hpet.c              |    2 +-
> ...
> diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
> index 0833896..10f3f04 100644
> --- a/drivers/char/hpet.c
> +++ b/drivers/char/hpet.c
> @@ -500,7 +500,7 @@ static int hpet_ioctl_ieon(struct hpet_dev *devp)
>  
>  		sprintf(devp->hd_name, "hpet%d", (int)(devp - hpetp->hp_dev));
>  		irq_flags = devp->hd_flags & HPET_SHARED_IRQ
> -						? IRQF_SHARED : IRQF_DISABLED;
> +						? IRQF_SHARED : 0;
>  		if (request_irq(irq, hpet_interrupt, irq_flags,
>  				devp->hd_name, (void *)devp)) {
>  			printk(KERN_ERR "hpet: IRQ %d is not free\n", irq);
> ...

Acked-by: Clemens Ladisch <clemens@...isch.de>


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/