linux-kernel - Re: [RFC PATCH 03/10] fadump: Register for firmware assisted dump.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1D6A3FC8-816D-4257-A50E-60D1FCE7259F@kernel.crashing.org>
Date:	Thu, 8 Sep 2011 13:34:15 -0500
From:	Kumar Gala <galak@...nel.crashing.org>
To:	Mahesh J Salgaonkar <mahesh@...ux.vnet.ibm.com>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Michael Ellerman <michael@...erman.id.au>,
	Haren Myneni <hbabu@...ibm.com>,
	Anton Blanchard <anton@...ba.org>,
	Milton Miller <miltonm@....com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [RFC PATCH 03/10] fadump: Register for firmware assisted dump.

> 
> diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
> index a88bf27..3031ea7 100644
> --- a/arch/powerpc/kernel/setup_64.c
> +++ b/arch/powerpc/kernel/setup_64.c
> @@ -63,6 +63,7 @@
> #include <asm/kexec.h>
> #include <asm/mmu_context.h>
> #include <asm/code-patching.h>
> +#include <asm/fadump.h>
> 
> #include "setup.h"
> 
> @@ -371,6 +372,13 @@ void __init setup_system(void)
> 	rtas_initialize();
> #endif /* CONFIG_PPC_RTAS */
> 
> +#ifdef CONFIG_FA_DUMP
> +	/*
> +	 * Setup Firmware-assisted dump.
> +	 */
> +	setup_fadump();

Is there a reason this has to be done here?  Can it be an initcall or called from platform init code?

> +#endif
> +

- k



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/