linux-kernel - Re: [PATCH v2] ASoC: omap: convert per-board modules to platform drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1315520956.4126.3.camel@finisterre.wolfsonmicro.main>
Date:	Thu, 08 Sep 2011 15:29:11 -0700
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linaro-dev@...ts.linaro.org,
	Mans Rullgard <mans.rullgard@...aro.org>,
	Jassi Brar <jassisinghbrar@...il.com>,
	alsa-devel@...a-project.org, Russell King <linux@....linux.org.uk>,
	Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Jarkko Nikula <jhnikula@...il.com>, linux-omap@...r.kernel.org,
	Liam Girdwood <lrg@...com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] ASoC: omap: convert per-board modules to platform
 drivers

On Thu, 2011-09-08 at 22:28 +0200, Arnd Bergmann wrote:
> On Thursday 08 September 2011 20:05:48 Mans Rullgard wrote:

> > I had the same thought, but I couldn't find a suitable string anywhere.
> > Are you suggesting an if(machine_is_foo()) cascade in omap_init_audio()?

> > I'll be the first to agree this patch is not particularly pretty.

> My general feeling is that practically every time someone writes
> machine_is_*(), they are doing it wrong. There are of course exceptions,
> but I would strongly recommend to have the initialization calling up
> from the board file into more general functions instead of having all
> boards calling the same function which then goes to board specific
> code again.

I have to agree, that seems tasteless. I'd expect something like
triggering registration of devices based off walking down a table of
machine IDs or something. One other issue to consider here is that we
don't want to discourage people from sharing machine drivers while we
can so it can't be completely automatic, it 

Perhaps some sort of generic machine type based mechanism for
instantiating drivers a bit like what's done with DMI might be useful,
video will have a similar issue I guess.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/