linux-kernel - Re: [patch] sched, rt: fix migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E68243C.7000404@am.sony.com>
Date:	Wed, 7 Sep 2011 19:11:08 -0700
From:	Frank Rowand <frank.rowand@...sony.com>
To:	Mike Galbraith <efault@....de>,
	Peter Zijlstra <peterz@...radead.org>
CC:	linux-kernel <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Paul E. McKenney" <paulmck@...ibm.com>,
	linux-rt-users <linux-rt-users@...r.kernel.org>
Subject: Re: [patch] sched, rt: fix migrate_enable() thinko

On 08/23/11 07:12, Mike Galbraith wrote:
> 
> Assigning mask = tsk_cpus_allowed(p) after p->migrate_disable = 0 ensures
> that we won't see a mask change.. no push/pull, we stack tasks on one CPU.
> 
> Also add a couple fields to sched_debug for the next guy.
> 
> Signed-off-by: Mike Galbraith <efault@....de>
> 
> ---

< snip >

> Index: linux-2.6/kernel/sched_debug.c
> ===================================================================
> --- linux-2.6.orig/kernel/sched_debug.c
> +++ linux-2.6/kernel/sched_debug.c
> @@ -235,6 +235,7 @@ void print_rt_rq(struct seq_file *m, int
>  	P(rt_throttled);
>  	PN(rt_time);
>  	PN(rt_runtime);
> +	P(rt_nr_migratory);
>  
>  #undef PN
>  #undef P
> @@ -484,6 +485,8 @@ void proc_sched_show_task(struct task_st
>  	P(se.load.weight);
>  	P(policy);
>  	P(prio);
> +	P(migrate_disable);
> +	P(rt.nr_cpus_allowed);
>  #undef PN
>  #undef __PN
>  #undef P



Fix compile error for CONFIG_SMP=n

Signed-off-by: Frank Rowand <frank.rowand@...sony.com>
---
 kernel/sched_debug.c |    2 	2 +	0 -	0 !
 1 file changed, 2 insertions(+)

Index: b/kernel/sched_debug.c
===================================================================
--- a/kernel/sched_debug.c
+++ b/kernel/sched_debug.c
@@ -235,7 +235,9 @@ void print_rt_rq(struct seq_file *m, int
 	P(rt_throttled);
 	PN(rt_time);
 	PN(rt_runtime);
+#ifdef CONFIG_SMP
 	P(rt_nr_migratory);
+#endif
 
 #undef PN
 #undef P

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/