| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20110909083134.GA21835@suse.de> Date: Fri, 9 Sep 2011 01:31:34 -0700 From: Greg KH <gregkh@...e.de> To: Donggeun Kim <dg77.kim@...sung.com> Cc: linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, akpm@...ux-foundation.org, jic23@....ac.kr, kyungmin.park@...sung.com Subject: Re: [PATCH v2] misc: Add driver for GP2AP002 proximity/ambient light sensor On Fri, Sep 09, 2011 at 05:22:26PM +0900, Donggeun Kim wrote: > SHARP GP2AP002 is proximity and ambient light sensor. > This patch supports it. > > Signed-off-by: Donggeun Kim <dg77.kim@...sung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com> > --- > Changes for v2 > - changed to expose lux > - changed request_irq to request_threaded_irq function > - added sysfs_notify function call Why? You should never do that unless you _really_ know what you are doing. > - cleaned up code > > Documentation/misc-devices/gp2ap002 | 44 +++ > drivers/misc/Kconfig | 10 + > drivers/misc/Makefile | 1 + > drivers/misc/gp2ap002.c | 488 ++++++++++++++++++++++++++++++++ > include/linux/platform_data/gp2ap002.h | 69 +++++ Shouldn't this be an iio driver instead of some random misc driver with an undocumented sysfs file (hint, use Documentation/ABI for documenting stuff...) ? greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists