linux-kernel - Re: [PATCH] usb: add new usb gadget for ACM and mass storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 09 Sep 2011 12:30:57 +0200
From:	"Michal Nazarewicz" <mina86@...a86.com>
To:	"Greg KH" <gregkh@...e.de>,
	"Klaus Schwarzkopf" <schwarzkopf@...sortherm.de>
Cc:	balbi@...com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: add new usb gadget for ACM and mass storage

> Am 08.09.2011 21:11, schrieb Greg KH:
>> Do you really mean "any later version"?

On Fri, 09 Sep 2011 10:37:06 +0200, Klaus Schwarzkopf  
<schwarzkopf@...sortherm.de> wrote:
> The acm_ms.c file is heavly based on the cdc2.c file with this  
> paragraph. Can i change this without breaking the license?

Probably yes, since you're adding your copyright and you can say that
your changes are GPLv2 only and therefore in practice the whole file
becomes GPLv2 only.

If anyone cares about my interpretation and opinion, Greg did not ask
you to change it but rather whether you really mean “any later version”. ;)

>> These two paragraphs are not needed, and the address is a very bad idea
>> to include in any file as it changes over time and I don't think you
>> want to keep up with the address location of the FSF for the next 40+
>> years.

> OK, i remove this lines.
>
> Can i remove this lines in all files of the directory drivers/usb/gadget?

If you do, submit it as separate patch. :)

> +#define CDC_VENDOR_NUM	0x1d6b	/* Linux Foundation */
> +#define CDC_PRODUCT_NUM	0x0106	/* CDC Composite: ACM + MS*/
>
> I used the next free device ID from http://www.linux-usb.org/usb.ids, is  
> this ok?

IIRC, Greg is maintaining lists of IDs, so you need to ask him nicely for
one. ;)

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michal "mina86" Nazarewicz    (o o)
ooo +-----<email/xmpp: mnazarewicz@...gle.com>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/