linux-kernel - Re: [PATCH] sched: share task comm length value to userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 9 Sep 2011 16:49:59 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Arjan van de Ven <arjan@...radead.org>,
	Vladimir Zapolskiy <vz@...ia.com>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] sched: share task comm length value to userspace

On Fri, 9 Sep 2011 16:41:30 -0700
Andrew Morton <akpm@...ux-foundation.org> wrote:

> 		if (prctl(PR_GET_NAME, (unsigned long)comm2, 0, 0, 0) < 0) {

Actually, if we were ever to increase sizeof(task_struct.comm),
existing code which does

	char comm[16];
	prctl(PR_GET_NAME, comm, ...)

will get its stack scribbled on.

So we _could_ increase it, but we'd need to retain the old 16-char
interfaces and add new prctl() modes.  And if we did that, we'd design
them in such a way that userspace wouldn't need to assume a fixed
size..

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/