linux-kernel - Re: [PATCH] autofs4/root.c: quiet sparse noise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1315635138.3171.1.camel@perseus.themaw.net>
Date:	Sat, 10 Sep 2011 14:12:18 +0800
From:	Ian Kent <raven@...maw.net>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	autofs@...ux.kernel.org
Subject: Re: [PATCH] autofs4/root.c: quiet sparse noise

On Fri, 2011-09-09 at 17:17 -0700, H Hartley Sweeten wrote:
> The function autofs4_d_manage is prototyped as a static function.
> Add static to the function to quiet the sparse noise:
> 
> warning: symbol 'autofs4_d_manage' was not declared. Should it be static?
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Ian Kent <raven@...maw.net>

Thought I had done that in the original series ....
Acked-by: Ian Kent <raven@...maw.net>

> 
> ---
> 
> diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c
> index f55ae23..366a9f2 100644
> --- a/fs/autofs4/root.c
> +++ b/fs/autofs4/root.c
> @@ -427,7 +427,7 @@ done:
>  	return NULL;
>  }
>  
> -int autofs4_d_manage(struct dentry *dentry, bool rcu_walk)
> +static int autofs4_d_manage(struct dentry *dentry, bool rcu_walk)
>  {
>  	struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb);
>  


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/