linux-kernel - Re: [PATCH 5/5] zram: Set initial disksize to some default value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E6AACF0.2080907@vflare.org>
Date:	Fri, 09 Sep 2011 20:18:56 -0400
From:	Nitin Gupta <ngupta@...are.org>
To:	Greg KH <greg@...ah.com>
CC:	Jerome Marchand <jmarchan@...hat.com>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Robert Jennings <rcj@...ux.vnet.ibm.com>,
	Linux Driver Project <devel@...uxdriverproject.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/5] zram: Set initial disksize to some default value

On 09/09/2011 07:12 PM, Greg KH wrote:

> On Fri, Sep 09, 2011 at 07:01:04PM -0400, Nitin Gupta wrote:
>> Currently, we set initial disksize as 0, which forces
>> user to write some value to corresponding zram device's
>> sysfs node, before the device can be used. Now, we avoid
>> this step by providing some default size initially.
>>
>> To change the disksize, user must:
>>  - Reset disk.
>> 	Ex: echo 1 > /sys/block/zram0/reset
>> (NOTE: disksize is set to the default value after reset)
>>
>>  - Set new disksize.
>> 	Ex: echo $((256*1024*1024)) > /sys/block/zram0/disksize
> 
> So, what tools just broke with this change?
> 
> And where is the sysfs file documentation change that should go along
> with this?
> 


This change does not change any sysfs names or behavior, so does not
break any scripts that assume the current behavior. I also verified that
sysfs documentation (ABI/testing/sysfs-block-zram) need not be changed
and same with drivers/staging/zram/zram.txt.

PS: zram_set_disksize() change (patch 1/5) also does not break any
documentation.

Thanks,
Nitin




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/