linux-kernel - Re: [PATCH 1/2] staging: et131x: Fix checkpatch whitespace warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 10 Sep 2011 17:34:36 +0100
From:	Mark Einon <mark.einon@...il.com>
To:	Dan Carpenter <error27@...il.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, o.hartmann@...ovital.com
Subject: Re: [PATCH 1/2] staging: et131x: Fix checkpatch whitespace warnings

On 10 September 2011 06:22, Dan Carpenter <error27@...il.com> wrote:
> On Sat, Sep 03, 2011 at 12:49:06PM +0100, Mark Einon wrote:
>> --- a/drivers/staging/et131x/et131x_netdev.c
>> +++ b/drivers/staging/et131x/et131x_netdev.c
>> @@ -408,7 +408,7 @@ void et131x_tx_timeout(struct net_device *netdev)
>>       unsigned long flags;
>>
>>       /* If the device is closed, ignore the timeout */
>> -     if (~(adapter->flags & fMP_ADAPTER_INTERRUPT_IN_USE));
>> +     if (~(adapter->flags & fMP_ADAPTER_INTERRUPT_IN_USE))
>>               return;
>>
>
> You fixed a bug here.  That's not mentioned in the commit message.
> Why would you want to keep that a secret?  Also it should go in a
> separate commit.

Oh yes, i did, didn't I? I must have forgot that was there.

Thanks for the spot.

Would you like it in a different patch?


Cheers,

 Mark
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/