linux-kernel - Re: Kernel 3.1.0-rc4 oops when connecting iPod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG1a4rvfajX8BwbL39UP5PYcwMLi_GETS3psq7cZv48UvZv0Ng@mail.gmail.com>
Date:	Sat, 10 Sep 2011 23:32:15 -0400
From:	Pavel Ivanov <paivanof@...il.com>
To:	Hin-Tak Leung <htl10@...rs.sourceforge.net>,
	Christoph Hellwig <hch@...era.com>,
	Pavel Ivanov <paivanof@...il.com>,
	linux-fsdevel@...r.kernel.org,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Seth Forshee <seth.forshee@...onical.com>
Subject: Re: Kernel 3.1.0-rc4 oops when connecting iPod

On Thu, Sep 8, 2011 at 12:23 PM, Seth Forshee
<seth.forshee@...onical.com> wrote:
> On Thu, Sep 08, 2011 at 04:13:01AM +0100, Hin-Tak Leung wrote:
>> --- On Wed, 7/9/11, Seth Forshee <seth.forshee@...onical.com> wrote:
>>
>> > Yes, that was definitely just an oversight. Has anyone
>> > provided a patch
>> > yet? If not I've pasted a patch below. Seems like a fix
>> > should be
>> > applied ASAP.
>> >
>> >
>> > From d27825b880028e9a45ba640d86c9e8101db0606b Mon Sep 17
>> > 00:00:00 2001
>> > From: Seth Forshee <seth.forshee@...onical.com>
>> > Date: Wed, 7 Sep 2011 10:38:35 -0700
>> > Subject: [PATCH] hfsplus: Fix kfree of wrong pointers in
>> > hfsplus_fill_super() error path
>> >
>> > Commit 6596528 (hfsplus: ensure bio requests are not
>> > smaller than
>> > the hardware sectors) changed the pointers used for volume
>> > header
>> > allocations but failed to change the pointer freed in the
>> > error
>> > path of hfsplus_fill_super(). This patch fixes the
>> > problem.
>> >
>> > Reported-by: Pavel Ivanov <paivanof@...il.com>
>> > Signed-off-by: Seth Forshee <seth.forshee@...onical.com>
>> > Cc: <stable@...nel.org>
>>
>> Acked-by: Hin-Tak Leung <htl10@...rs.sourceforge.net>
>>
>> Please go ahead and submit the patch.
>
> That was my patch submission :)
>
> Christoph, does that work for you, or would you like me to send the
> patch in a separate email?

Seth, Christoph,

I've just found another wrong pointers freeing. The following patch
should fix it.



Subject: [PATCH] hfsplus: Fix kfree of wrong pointers in
hfsplus_read_wrapper() error path

Commit 6596528 (hfsplus: ensure bio requests are not smaller than
the hardware sectors) changed the pointers used for volume header
allocations but failed to change the pointer freed in the error
path of hfsplus_read_wrapper(). This patch fixes the problem.

Signed-off-by: Pavel Ivanov <paivanof@...il.com>
Cc: <stable@...nel.org>
---

diff --git a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c
index 10e515a..7daf4b8 100644
--- a/fs/hfsplus/wrapper.c
+++ b/fs/hfsplus/wrapper.c
@@ -272,9 +272,9 @@ reread:
 	return 0;

 out_free_backup_vhdr:
-	kfree(sbi->s_backup_vhdr);
+	kfree(sbi->s_backup_vhdr_buf);
 out_free_vhdr:
-	kfree(sbi->s_vhdr);
+	kfree(sbi->s_vhdr_buf);
 out:
 	return error;
 }
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/