linux-kernel - Re: [PATCH] arch/x86/mm/init_32.c: quiet sparse noise; local functions should be static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110911010739.GH29319@htj.dyndns.org>
Date:	Sun, 11 Sep 2011 10:07:39 +0900
From:	Tejun Heo <tj@...nel.org>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>, x86@...nel.org,
	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	yinghai@...nel.org, bp@...en8.de
Subject: Re: [PATCH] arch/x86/mm/init_32.c: quiet sparse noise; local
 functions should be static

On Fri, Sep 09, 2011 at 04:09:23PM -0700, H Hartley Sweeten wrote:
> Local functions should be marked static.  This quiets the following
> sparse noise:
> 
> warning: symbol 'lowmem_pfn_init' was not declared. Should it be static?
> warning: symbol 'highmem_pfn_init' was not declared. Should it be static?
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers,com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: Tejun Heo <tj@...nel.org>
> Cc: Yinghai Lu <yinghai@...nel.org>
> Cc: Borislav Petkov <bp@...en8.de> 

Looks good to me.

 Reviewed-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/