lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 11 Sep 2011 10:37:42 +0900 From: Tejun Heo <tj@...nel.org> To: Matt Helsley <matthltc@...ibm.com> Cc: Oleg Nesterov <oleg@...hat.com>, rjw@...k.pl, paul@...lmenage.org, containers@...ts.linux-foundation.org, linux-pm@...ts.linux-foundation.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 6/6] freezer: kill unused set_freezable_with_signal() Hello, Matt. On Thu, Sep 08, 2011 at 11:01:59AM -0700, Matt Helsley wrote: > Looking at the code and docs I realize I didn't explicitly mention that > kthreads could not be frozen by the cgroup freezer. However, the code did > not allow it. When freezing tasks the cgroup freezer always did: > > freeze_task(task, true) > > which would only freeze tasks without PF_FREEZER_NOSIG due to the second > "sig_only" parameter. I believe this means it could not be used to > freeze kthreads. > > My feeling is kthreads should not be "managed" directly by userspace. > Especially if that includes the ability to arbitrarily stop or freeze them. > So it seems more appropriate to explicitly disallow freezing of kthreads > via the cgroup freezer. Oh yeah, that's what we should do and maybe that's what the current code intends to achieve too but currently it ends up triggering BUG_ON(). Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists