linux-kernel - Re: [patch v3 14/36] Hexagon: Add signal functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1315753158.455.53.camel@pasglop>
Date:	Sun, 11 Sep 2011 11:59:18 -0300
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Richard Kuo <rkuo@...eaurora.org>
Cc:	linux-arch@...r.kernel.org, linux-hexagon@...r.kernel.org,
	linux-kernel@...r.kernel.org, Linas Vepstas <linas@...eaurora.org>
Subject: Re: [patch v3 14/36] Hexagon: Add signal functions

On Thu, 2011-09-08 at 20:09 -0500, Richard Kuo wrote:

> +#define _BLOCKABLE (~(sigmask(SIGKILL) | sigmask(SIGSTOP)))
> +
> +struct sigframe {
> +	unsigned long pad[2]; /* Used to be signal tramp */
> +	struct sigcontext sc;
> +	sigset_t mask;
> +};
> +
> +struct rt_sigframe {
> +	unsigned long pad[2]; /* Used to be signal tramp */
> +	struct siginfo info;
> +	struct ucontext uc;
> +};

Why did you make two types of signal frames ? It's an unnecessary
complication... Dunno if you can still fix that (if you can still
control your ABI that is), but you should look how ppc64 uses the same
frame for RT and non-RT, avoids duplication of bugs :-)

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/