linux-kernel - Re: [PATCH] jsm: Fixed EEH recovery error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110912153508.GA8851@oc1711230544.ibm.com>
Date:	Mon, 12 Sep 2011 12:35:08 -0300
From:	Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>
To:	Lucas Kannebley Tavares <lucaskt@...ux.vnet.ibm.com>
Cc:	Breno Leitao <leitao@...ux.vnet.ibm.com>,
	Alan Cox <alan@...ux.intel.com>, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] jsm: Fixed EEH recovery error

On Mon, Sep 12, 2011 at 10:36:05AM -0300, Lucas Kannebley Tavares wrote:
> There was an error on the jsm driver that would cause it to be unable to
> recover after a second error is detected.
> 
> At the first error, the device recovers properly:
> 
> [72521.485691] EEH: Detected PCI bus error on device 0003:02:00.0
> [72521.485695] EEH: This PCI device has failed 1 times in the last hour:
> ...
> [72532.035693] ttyn3 at MMIO 0x0 (irq = 49) is a jsm
> [72532.105689] jsm: Port 3 added
> 
> However, at the second error, it cascades until EEH disables the device:
> 
> [72631.229549] Call Trace:
> ...
> [72641.725687] jsm: Port 3 added
> [72641.725695] EEH: Detected PCI bus error on device 0003:02:00.0
> [72641.725698] EEH: This PCI device has failed 3 times in the last hour:
> 
> It was caused because the PCI state was not being saved after the first
> restore. Therefore, at the second recovery the PCI state would not be
> restored.
> 
> Signed-off-by: Lucas Kannebley Tavares <lucaskt@...ux.vnet.ibm.com>

Acked-by: Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>

> ---
>  drivers/tty/serial/jsm/jsm_driver.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/tty/serial/jsm/jsm_driver.c b/drivers/tty/serial/jsm/jsm_driver.c
> index 96da178..8941b15 100644
> --- a/drivers/tty/serial/jsm/jsm_driver.c
> +++ b/drivers/tty/serial/jsm/jsm_driver.c
> @@ -270,6 +270,7 @@ static void jsm_io_resume(struct pci_dev *pdev)
>  	struct jsm_board *brd = pci_get_drvdata(pdev);
> 
>  	pci_restore_state(pdev);
> +	pci_save_state(pdev);
> 
>  	jsm_uart_port_init(brd);
>  }
> -- 
> 1.7.4.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/