linux-kernel - Re: [PATCH 1/3] iommu/core: add fault reporting mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK=WgbZCDsBk+dueKfAX3ewsvqEnVDN+jW_ftW+BDKnayunOwA@mail.gmail.com>
Date:	Mon, 12 Sep 2011 19:21:13 +0300
From:	Ohad Ben-Cohen <ohad@...ery.com>
To:	"Roedel, Joerg" <Joerg.Roedel@....com>
Cc:	"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	Hiroshi DOYU <Hiroshi.DOYU@...ia.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	David Woodhouse <dwmw2@...radead.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	David Brown <davidb@...eaurora.org>,
	Arnd Bergmann <arnd@...db.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] iommu/core: add fault reporting mechanism

On Mon, Sep 12, 2011 at 7:02 PM, Roedel, Joerg <Joerg.Roedel@....com> wrote:
> I still don't get the need for this. It would make sense to encode
> different types of faults, like page-faults or interrupt-faults.

Right.

> When I read the comment above it sounds more like you want to encode
> different error-levels, like recoverable and unrecoverable error.
> The exact meaning of these values need to be clarified.

Well, we currently only need to say "something bad has happened".

We don't need at this point to tell whether it's a hardware bug,
inconsistent data, missing page-table entries or whatnot, because we
don't expect the user (or the iommu core itself) to do anything about
it. Not that it's not possible though: a valid response one day would
be to fix the page-table or add a missing TLB (depending on the mode
the hardware is configured to) but this is not (yet?) implemented. So
a "general unrecoverable error" is enough at this point, but it's
certainly makes sense to allow drivers to provide additional types of
errors/faults - once they are implemented.

> Please place 'event' before iova when you keep it, and not at the end.
> Then you have 'where' and 'what' of the fault first before the details
> (iova, flags).

Will do.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/