linux-kernel - Re: [PATCH 1/4] dynamic_debug: consolidate repetitive struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfuBxysYL+Co3vDnWKYX_nJHaFoq9MJ9o4DP1Djwh84nm7HJA@mail.gmail.com>
Date:	Mon, 12 Sep 2011 12:15:32 -0600
From:	Jim Cromie <jim.cromie@...il.com>
To:	Jason Baron <jbaron@...hat.com>
Cc:	Joe Perches <joe@...ches.com>,
	Andrew Morton <akpm@...ux-foundation.org>, gregkh@...e.de,
	Bart Van Assche <bvanassche@....org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] dynamic_debug: consolidate repetitive struct _ddebug
 descriptor definitions

>> No real idea why it's aligned(8).  Jason?
>>
>
> I think when I first implemented it, I noticed that subsystems that did
> similar things, set aligned(8) in include/asm-generic/vmlinux.lds.h. For
> example, FTRACE_EVENTS() sets ALIGN(8)...I know that not a great reason
> thouh :( Don't remember if I tried ALIGN(4), but if it saves space, we
> can look at it...
>

I tried it here on 32bit (on 586 class machine), it blew up.
I imagine it could be made to work, but its not a gimme.

> Also, as I mentioned before, we probably need an extra array of pointers into
> the dynamic debug structures. see: https://lkml.org/lkml/2011/1/26/463.
>

I'll try it again, once this happens.

> thanks,
>
> -Jason
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/