linux-kernel - Re: [PATCH] Fix repeatable Oops on container destroy with conntrack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110912093749.GE2194@1984>
Date:	Mon, 12 Sep 2011 11:37:49 +0200
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Alex Bligh <alex@...x.org.uk>, netfilter-devel@...r.kernel.org,
	netfilter@...r.kernel.org, coreteam@...filter.org,
	linux-kernel@...r.kernel.org,
	containers@...ts.linux-foundation.org,
	Linux Containers <containers@...ts.osdl.org>
Subject: Re: [PATCH] Fix repeatable Oops on container destroy with conntrack

On Mon, Sep 12, 2011 at 10:25:24AM +0300, Alexey Dobriyan wrote:
> On Sat, Sep 10, 2011 at 07:48:43PM +0100, Alex Bligh wrote:
> > --- a/net/netfilter/nf_conntrack_netlink.c
> > +++ b/net/netfilter/nf_conntrack_netlink.c
> > @@ -570,6 +570,11 @@ ctnetlink_conntrack_event(unsigned int events, struct nf_ct_event *item)
> >  		return 0;
> > 
> >  	net = nf_ct_net(ct);
> > +
> > +	/* container deinit, netlink may have died before death_by_timeout */
> > +	if (!net->nfnl)
> > +		return 0;
> > +
> >  	if (!item->report && !nfnetlink_has_listeners(net, group))
> >  		return 0;
> 
> If this is correct fix, ->nfnl check should be folded into
> nfnetlink_has_listeners(), otherwise expectations aren't covered.

Agreed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/