linux-kernel - Re: [PATCH 2/2] block: remove support for bio remapping from ->make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E6DD818.80902@kernel.dk>
Date:	Mon, 12 Sep 2011 11:59:52 +0200
From:	Jens Axboe <axboe@...nel.dk>
To:	Christoph Hellwig <hch@...radead.org>
CC:	linux-raid@...r.kernel.org, dm-devel@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] block: remove support for bio remapping from ->make_request

On 2011-09-11 16:51, Christoph Hellwig wrote:
> There is very little benefit in allowing to let a ->make_request
> instance update the bios device and sector and loop around it in
> __generic_make_request when we can archive the same through calling
> generic_make_request from the driver and letting the loop in
> generic_make_request handle it.

Agree, this looks good! Will apply for 3.2.

> Note that various drivers got the return value from ->make_request and
> returned non-zero values for errors.

Hadn't noticed that, I guess the return values are easy to get wrong in
that case. Never a good sign.


-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/