linux-kernel - Re: [PATCH v2] sound: usb: mixer: increase control transfer timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hr53m6nb1.wl%tiwai@suse.de>
Date:	Mon, 12 Sep 2011 12:57:06 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Jassi Brar <jassisinghbrar@...il.com>
Cc:	Clemens Ladisch <clemens@...isch.de>, Felipe Balbi <balbi@...com>,
	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org,
	Linux USB Mailing List <linux-usb@...r.kernel.org>
Subject: Re: [PATCH v2] sound: usb: mixer: increase control transfer timeout

At Mon, 29 Aug 2011 19:52:09 +0530,
Jassi Brar wrote:
> 
> On Mon, Aug 29, 2011 at 7:35 PM, Clemens Ladisch <clemens@...isch.de> wrote:
> 
> >> > +                                   buf, val_len, 1000) >= val_len) {
> >> > +                                   buf, val_len, 1000) >= 0) {
> >> > +                             !value, 0, NULL, 0, 1000);
> >> > +                             !value, 0, NULL, 0, 1000);
> >> > +                             value, index + 2, NULL, 0, 1000);
> >> > +                                     jacks[i].unitid << 8, buf, 3, 1000);
> >> > +                             50, 0, &new_status, 1, 1000);
> >>
> >> How about also converting to use a local define for timeout value ?
> >
> > ... now that _all_ calls to snd_usb_ctl_msg use the same timeout value,
> > we could just as well drop this parameter.
> Sounds better, esp when we have 9 arguments to snd_usb_ctl_msg!

Indeed, I'd like to see the reduced arguments, too.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/