linux-kernel - Re: [PATCH 2/4 v6] pinmux: add a driver for the U300 pinmux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdan_g6dBvuXwbAdtHFd14GLkKsKLcHnybTuNGmYiqcStA@mail.gmail.com>
Date:	Tue, 13 Sep 2011 15:06:23 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Stephen Warren <swarren@...dia.com>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Lee Jones <lee.jones@...aro.org>,
	Joe Perches <joe@...ches.com>,
	Russell King <linux@....linux.org.uk>,
	Linaro Dev <linaro-dev@...ts.linaro.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	David Brown <davidb@...eaurora.org>,
	Barry Song <21cnbao@...il.com>
Subject: Re: [PATCH 2/4 v6] pinmux: add a driver for the U300 pinmux

On Fri, Sep 2, 2011 at 6:04 PM, Stephen Warren <swarren@...dia.com> wrote:
> Linus Walleij wrote at Friday, September 02, 2011 2:12 AM:
>> On Thu, Sep 1, 2011 at 11:33 PM, Stephen Warren <swarren@...dia.com> wrote:
>>
>> >> +static const struct u300_pmx_func u300_pmx_functions[] = {
>> >> +     {
>> >> +             .name = "power",
>> >> +             .groups = { POWERGRP_INDEX },
>> >> +             /* Mask is N/A */
>> >> +     },
>> >
>> > Hmmm. That's a lot of _INDEX defines that'd need to be set up, at least
>> > to fully represent a chip like Tegra. Can the pinmux core be modified
>> > such that the group list is an array of names (char*) rather than the
>> > actual numeric IDs of the groups? Still, perhaps we could use the enum
>> > we already have for this, so perhaps it isn't a big deal...
>>
>> Well I could think about a lot of ways to do this, but it's basically up
>> to the driver, the U300 is just some simple example of what you can
>> do, it's just trying to satisfy the API.
>>
>> Maybe as part of writing the nVidia driver you find a clever
>> mechanism for doing this, if it's looking generally useful at that
>> point then let's move it to the core I'd say.
>
> The reason I asked about the pinmux core handling this is because the
> driver op get_function_groups:
>
> +       int (*get_function_groups) (struct pinctrl_dev *pctldev,
> +                                 unsigned selector,
> +                                 unsigned ** const groups,
> +                                 unsigned * const num_groups);
>
> returns an array of integer indexes. I think the only way to get rid of
> the index definitions in the drivers is to allow get_function_groups to
> return an array of strings instead.

OK good idea, I reworked this interface to get an array of strings
instead, I've been told several times to use strings rather than numbers
when possible, so I think this is the right thing to do.

Check it out in v7!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/