lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110913144051.GA23034@ghostprotocols.net>
Date:	Tue, 13 Sep 2011 11:40:51 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Stephane Eranian <eranian@...gle.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	David Ahern <dsahern@...il.com>, linux-kernel@...r.kernel.org,
	mingo@...e.hu
Subject: Re: [PATCH] perf: make perf.data more self-descriptive (v4)

Em Mon, Sep 12, 2011 at 04:47:21PM +0200, Stephane Eranian escreveu:
> On Mon, Sep 12, 2011 at 4:43 PM, Peter Zijlstra <peterz@...radead.org> wrote:
> > On Mon, 2011-09-12 at 16:40 +0200, Stephane Eranian wrote:
> >> I don't think this should be the test to detect endianess.
> >
> > You should be able to tell the endianness from the PERF_MAGIC string, it
> > stores the string as a u64, so depending on endianness it reads back as
> > either: PERFFILE or ELIFFREP or whatever the bswap64 result is.
> >
> right, something like that...

Yeah, right, reading this thread I could swear it was done like that :-\

Just set needs_swap based on the magic number in perf_file_header__read().

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ