linux-kernel - Re: [PATCH] Janitor: Typo in stack debug code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL4Wiioh69CYAnbJnCuQM8cs19eWCsXF8p_rwAswBWQfe5+rWQ@mail.gmail.com>
Date:	Tue, 13 Sep 2011 18:31:14 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	"Linas Vepstas (Code Aurora)" <linas@...eaurora.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Janitor: Typo in stack debug code

2011/9/13 Linas Vepstas (Code Aurora) <linas@...eaurora.org>:
>
> In the debug routine check_stack_usage(), free stack space is counted
> in units of (unsigned long), not bytes.  Make this clear when printing.
>
> It seems easiest to just change the message, instead of multiplying
> by sizeof(unsigned long).
>
> Signed-off-by: Linas Vepstas <linas@...eaurora.org>
>
> ---
>
> ===================================================================
> --- a/kernel/exit.c
> +++ b/kernel/exit.c
> @@ -888,7 +888,7 @@ static void check_stack_usage(void)
>
>        spin_lock(&low_water_lock);
>        if (free < lowest_to_date) {
> -               printk(KERN_WARNING "%s used greatest stack depth: %lu bytes "
> +               printk(KERN_WARNING "%s used greatest stack depth: %lu words "
>                                "left\n",
>                                current->comm, free);
>                lowest_to_date = free;
>
>
>
>

Thats not true, everything is fine.

dmesg | grep stack
[    1.564907] kworker/u:0 used greatest stack depth: 5592 bytes left
[    2.467909] modprobe used greatest stack depth: 5576 bytes left
[    2.483228] exe used greatest stack depth: 5552 bytes left
[    2.489430] all_generic_ide used greatest stack depth: 5496 bytes left
[    2.524731] scsi_id used greatest stack depth: 5440 bytes left
[    2.643103] blkid used greatest stack depth: 4768 bytes left
[    4.232051] exe used greatest stack depth: 4320 bytes left
[    4.761443] stty used greatest stack depth: 3784 bytes left
[    6.011566] modprobe used greatest stack depth: 3664 bytes left
[    6.011681] modprobe used greatest stack depth: 3184 bytes left
[  339.890273] nroff used greatest stack depth: 3032 bytes left
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/