linux-kernel - Re: [PATCH v4] drivers/block/mtip32xx: Adding new driver mtip32xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJqx+goSvc75q0gr3AkG3RqXi5_rUCuy+igx9+EZBFvyZLj39A@mail.gmail.com>
Date:	Tue, 13 Sep 2011 09:46:07 -0700
From:	Eric Seppanen <eds@...ic.net>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	"Sam Bradshaw (sbradshaw)" <sbradshaw@...ron.com>,
	jaxboe@...ionio.com, alan@...rguk.ukuu.org.uk,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jeff Garzik <jgarzik@...ox.com>, jmoyer@...hat.com,
	"Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONTRACTOR]" 
	<asamymuthupa@...ron.com>
Subject: Re: [PATCH v4] drivers/block/mtip32xx: Adding new driver mtip32xx

On Tue, Sep 13, 2011 at 5:49 AM, Christoph Hellwig <hch@...radead.org> wrote:
> Btw, there is another _huge_ issue with the driver, and that is the
> lack of any internal queueing.  Remember the make_request interface is
> an extremly thin layer (or rather the lack of it) below the filesystem.
>
> So for example if eh_active is non-zero you return -EBUSY to the
> filesystems.  That's an error code it a) doesn't recognize and b)
> couldn't handle even if it did.  Similarly mtip_hw_get_scatterlist
> simply blocks if no tag is currently available instead of queueing
> it up.

Just out of curiosity, why is blocking on no-tag-available a bad
thing?  How is it any different than the blocking that will occur when
a request queue is full?  When the hardware queue depth is bigger than
that of a request queue, what extra benefit does queuing give?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/