linux-kernel - Re: [PATCH Resend][Trivial] Match on_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E6FA8AE.5010308@xenotime.net>
Date:	Tue, 13 Sep 2011 12:02:06 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Gilad Ben-Yossef <gilad@...yossef.com>
CC:	linux-kernel@...r.kernel.org, Jiri Kosina <trivial@...nel.org>
Subject: Re: [PATCH Resend][Trivial] Match on_each_cpu behaviour on UP to
 SMP

On 09/07/11 23:57, Gilad Ben-Yossef wrote:
> The comment in the SMP implementation of on_each_cpu says:
>  "May be used during early boot while
>   early_boot_irqs_disabled is set.  Use local_irq_save/restore() instead
>   of local_irq_disable/enable()."
> 
> but the existing UP macro version uses local_irq_disable/enable().
> 
> Do the safe thing - make the UP version match the SMP one.
> 
> Signed-off-by: Gilad Ben-Yossef <gilad@...yossef.com>
> CC: Jiri Kosina <trivial@...nel.org>
> ---
>  include/linux/smp.h |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/smp.h b/include/linux/smp.h
> index 8cc38d3..7c9b9d4 100644
> --- a/include/linux/smp.h
> +++ b/include/linux/smp.h
> @@ -127,9 +127,10 @@ static inline int up_smp_call_function(smp_call_func_t func, void *info)
>  			(up_smp_call_function(func, info))
>  #define on_each_cpu(func,info,wait)		\
>  	({					\
> -		local_irq_disable();		\
> +		unsigned long __flags;		\
> +		local_irq_save(__flags);	\
>  		func(info);			\
> -		local_irq_enable();		\
> +		local_irq_retore(__flags);	\

You tested that?          ^^^^^^


>  		0;				\
>  	})
>  static inline void smp_send_reschedule(int cpu) { }


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/