linux-kernel - RE: [PATCH 1/1] Staging: hv: netvsc: Cleanup the name and type of link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 Sep 2011 20:57:50 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Joe Perches <joe@...ches.com>
CC:	"gregkh@...e.de" <gregkh@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"virtualization@...ts.osdl.org" <virtualization@...ts.osdl.org>,
	Haiyang Zhang <haiyangz@...rosoft.com>
Subject: RE: [PATCH 1/1] Staging: hv: netvsc: Cleanup the name and type of
 link_stat variable



> -----Original Message-----
> From: Joe Perches [mailto:joe@...ches.com]
> Sent: Tuesday, September 13, 2011 4:05 PM
> To: KY Srinivasan
> Cc: gregkh@...e.de; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; virtualization@...ts.osdl.org; Haiyang Zhang
> Subject: Re: [PATCH 1/1] Staging: hv: netvsc: Cleanup the name and type of
> link_stat variable
> 
> On Tue, 2011-09-13 at 12:53 -0700, K. Y. Srinivasan wrote:
> > Consistently name the variable tracking the link status. Use a consistent
> > type for this variable and get rid of some unnecessary parentheses as well.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> > Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> > ---
> >  drivers/staging/hv/rndis_filter.c |    8 ++++----
> >  1 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/hv/rndis_filter.c b/drivers/staging/hv/rndis_filter.c
> > index 963582a..696d2c5 100644
> > --- a/drivers/staging/hv/rndis_filter.c
> > +++ b/drivers/staging/hv/rndis_filter.c
> > @@ -41,7 +41,7 @@ struct rndis_device {
> >  	struct netvsc_device *net_dev;
> >
> >  	enum rndis_device_state state;
> > -	u32 link_stat;
> > +	bool link_state;
> >  	atomic_t new_req_id;
> >
> >  	spinlock_t request_lock;
> > @@ -514,7 +514,7 @@ static int rndis_filter_query_device_link_status(struct
> rndis_device *dev)
> >
> >  	return rndis_filter_query_device(dev,
> >  				      RNDIS_OID_GEN_MEDIA_CONNECT_STATUS,
> > -				      &dev->link_stat, &size);
> > +				      &dev->link_state, &size);
> 
> Are you sure you can do this?
> You're changing the info request from u32 to bool
> without changing the size above it

Oops! I will fix this.

> 
> 	u32 size = sizeof(u32);
> 
> 
> >  }
> >
> >  static int rndis_filter_set_packet_filter(struct rndis_device *dev,
> > @@ -736,11 +736,11 @@ int rndis_filter_device_add(struct hv_device *dev,
> >
> >  	rndis_filter_query_device_link_status(rndis_device);
> >
> > -	device_info->link_state = rndis_device->link_stat;
> > +	device_info->link_state = rndis_device->link_state;
> >
> >  	dev_info(&dev->device, "Device MAC %pM link state %s",
> >  		 rndis_device->hw_mac_adr,
> > -		 ((device_info->link_state) ? ("down\n") : ("up\n")));
> > +		 device_info->link_state ? "down\n" : "up\n");
> 
> It's better to remove the multiple "\n"s from "up" and "down"
> and move it to the format string as I suggested.

I will fix it.

Thank you,

K. Y