lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Sep 2011 07:48:39 +0200 From: Johannes Weiner <jweiner@...hat.com> To: "Kirill A. Shutemov" <kirill@...temov.name> Cc: Andrew Morton <akpm@...ux-foundation.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>, Daisuke Nishimura <nishimura@....nes.nec.co.jp>, Balbir Singh <bsingharora@...il.com>, Ying Han <yinghan@...gle.com>, Michal Hocko <mhocko@...e.cz>, Greg Thelen <gthelen@...gle.com>, Michel Lespinasse <walken@...gle.com>, Rik van Riel <riel@...hat.com>, Minchan Kim <minchan.kim@...il.com>, Christoph Hellwig <hch@...radead.org>, linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: Re: [patch 02/11] mm: vmscan: distinguish global reclaim from global LRU scanning On Tue, Sep 13, 2011 at 02:02:46AM +0300, Kirill A. Shutemov wrote: > On Mon, Sep 12, 2011 at 12:57:19PM +0200, Johannes Weiner wrote: > > @@ -1508,6 +1524,12 @@ shrink_inactive_list(unsigned long nr_to_scan, struct zone *zone, > > if (scanning_global_lru(sc)) { > > nr_taken = isolate_pages_global(nr_to_scan, &page_list, > > &nr_scanned, sc->order, reclaim_mode, zone, 0, file); > > + } else { > > + nr_taken = mem_cgroup_isolate_pages(nr_to_scan, &page_list, > > + &nr_scanned, sc->order, reclaim_mode, zone, > > + sc->mem_cgroup, 0, file); > > + } > > Redundant braces. I usually keep them for multiline branches, no matter how any statements. But this is temporary anyway, 10/11 gets rid of this branch, leaving only nr_taken = isolate_pages(...) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists