linux-kernel - Re: [PATCHv4 00/19] First round in OTG rework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E6F0CC7.7040208@compulab.co.il>
Date:	Tue, 13 Sep 2011 10:56:55 +0300
From:	Igor Grinberg <grinberg@...pulab.co.il>
To:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
CC:	Li Yang <leoli@...escale.com>,
	Pavankumar Kondeti <pkondeti@...eaurora.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Felipe Balbi <balbi@...com>, Greg KH <gregkh@...e.de>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Peter Chen <peter.chen@...escale.com>,
	Lin Tony-B19295 <B19295@...escale.com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Subject: Re: [PATCHv4 00/19] First round in OTG rework

On 09/12/11 15:12, Heikki Krogerus wrote:
> Hi guys,
> 
> On Wed, Sep 07, 2011 at 10:15:53AM +0300, Heikki Krogerus wrote:
>> There were no comments in two weeks, so I'm dropping the RFC. 
>> Otherwise this is the same as the previous, no changes.
>>
>> Quick summary:
>> This introduces struct usb_phy and struct usb_otg that
>> replace struct otg_transceiver. The transceiver and phy
>> members from struct otg_transceiver are left in struct
>> usb_phy and otg specific members are moved to struct
>> usb_otg.
>>
>> So the idea is simply to separate USB PHY handling from OTG.
>>
>> Heikki Krogerus (19):
>>   usb: otg: Rename otg_transceiver to usb_phy
>>   usb: otg: Rename usb_otg and usb_xceiv to usb_phy
>>   usb: otg: Separate otg members from usb_phy
>>   usb: otg: ab8500: Start using struct usb_otg
>>   usb: otg: fsl: Start using struct usb_otg
>>   usb: otg: gpio_vbus: Start using struct usb_otg
>>   usb: otg: isp1301_omap: Start using struct usb_otg
>>   usb: otg: msm: Start using struct usb_otg
>>   usb: otg: langwell: Start using struct usb_otg
>>   usb: otg: nop: Start using struct usb_otg
>>   usb: otg: twl4030: Start using struct usb_otg
>>   usb: otg: twl6030: Start using struct usb_otg
>>   usb: otg: ulpi: Start using struct usb_otg
>>   arm: imx: Start using struct usb_otg
>>   usb: musb: Start using struct usb_otg
>>   power_supply: Convert all users to new usb_phy
>>   usb: Convert all users to new usb_phy
>>   usb: otg: Remove OTG specific members from usb_phy
>>   usb: otg: Convert all users to pass struct usb_otg for OTG functions
> 
> You guys are maintainers of the tranceiver/otg drivers. Can you test
> these and ACK the patch for your driver if you feel there is nothing
> wrong with these? I would much appreciate.
> 

Currently, I cannot test this on my PXA3xx board, but I went through
the patches and it looks fine.
So,

Acked-by: Igor Grinberg <grinberg@...pulab.co.il>

for:
pxa3xx and drivers/usb/otg/ulpi.c

Would be nice to have the Acked/Tested-by from iMX guys.

-- 
Regards,
Igor.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/