linux-kernel - Re: [PATCH] Fix repeatable Oops on container destroy with conntrack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110914013500.GB17051@1984>
Date:	Wed, 14 Sep 2011 03:35:00 +0200
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Alex Bligh <alex@...x.org.uk>
Cc:	Alexey Dobriyan <adobriyan@...il.com>,
	netfilter-devel@...r.kernel.org, netfilter@...r.kernel.org,
	coreteam@...filter.org, linux-kernel@...r.kernel.org,
	containers@...ts.linux-foundation.org,
	Linux Containers <containers@...ts.osdl.org>
Subject: Re: [PATCH] Fix repeatable Oops on container destroy with conntrack

On Tue, Sep 13, 2011 at 09:44:38PM +0100, Alex Bligh wrote:
> Alexey / Pablo,
> 
> --On 12 September 2011 20:06:25 +0100 Alex Bligh <alex@...x.org.uk> wrote:
> 
> >Pablo,
> >
> >--On 12 September 2011 20:33:57 +0200 Pablo Neira Ayuso
> ><pablo@...filter.org> wrote:
> >
> >>Yes, this is what Alexey was pointing out in the previous email and
> >>why he suggested to move it to nfnetlink_has_listeners (to cover the
> >>expectation case).
> >>
> >>But you're right, we cannot move it to nfnetlink_has_listeners because
> >>of the item->report case. Please, include the expectation part and
> >>resend the patch.
> >
> >Thanks - see below
> 
> Is this new version OK? I am happy to adjust if not.

Hm, I still think that this is a workaround.

The nice fix should move nf_conntrack_event_cb in
nf_conntrack_ecache.c to the net container structure.

Alexey?

> I think we ought to get /something/ in, because without anything it's
> very simple to cause an oops and a resultant machine hang.

Sure, I'm all for fixing it :-).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/