linux-kernel - Re: [PATCH] ASoC: samsung: Fix checking return value of clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF+7xWkkHFA-omWg88bZgZPe_s5aUF--HBOyf8Dr_b7ML-HuFQ@mail.gmail.com>
Date:	Wed, 14 Sep 2011 10:05:55 +0800
From:	Axel Lin <axel.lin@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	linux-kernel@...r.kernel.org,
	Christian Pellegrin <chripell@...lware.org>,
	Ben Dooks <ben@...tec.co.uk>,
	Jassi Brar <jassisinghbrar@...il.com>,
	Sangbeom Kim <sbkim73@...sung.com>, Liam Girdwood <lrg@...com>,
	alsa-devel@...a-project.org
Subject: Re: [PATCH] ASoC: samsung: Fix checking return value of clk_get

2011/9/13 Mark Brown <broonie@...nsource.wolfsonmicro.com>:
> On Tue, Sep 13, 2011 at 10:44:22PM +0800, Axel Lin wrote:
>> clk_get() returns a pointer to the struct clk or an ERR_PTR().
>
> Are you sure that the Samsung clock implementation actually does this?
>

Yes.
In arch/arm/Kconfig, all samsung platforms select CLKDEV_LOOKUP.
The implementation of clk_get() in drivers/clk/clkdev.c returns
ERR_PTR() on failure.

Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/