linux-kernel - Re: [PATCH] Kbuild: append missing-syscalls to the default target list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACqU3MUFyn_jh2pN4GLENqcGVUzAwcMJUR_WLY2EtqOhMheceQ@mail.gmail.com>
Date:	Wed, 14 Sep 2011 01:17:10 -0400
From:	Arnaud Lacombe <lacombar@...il.com>
To:	Michal Marek <mmarek@...e.cz>
Cc:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Kbuild: append missing-syscalls to the default target list

Hi,

2011/9/9 Michal Marek <mmarek@...e.cz>:
> On 25.8.2011 03:03, Arnaud Lacombe wrote:
>> This avoid an extra make invocation on `prepare0'.
>>
>> Signed-off-by: Arnaud Lacombe <lacombar@...il.com>
>> ---
>>  Kbuild   |    4 +++-
>>  Makefile |    1 -
>>  2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/Kbuild b/Kbuild
>> index 2114113..1a2eb32 100644
>> --- a/Kbuild
>> +++ b/Kbuild
>> @@ -88,10 +88,12 @@ $(obj)/$(offsets-file): arch/$(SRCARCH)/kernel/asm-offsets.s Kbuild
>>  # 3) Check for missing system calls
>>  #
>>
>> +always += missing-syscalls
>> +targets += missing-syscalls
>> +
>>  quiet_cmd_syscalls = CALL    $<
>>        cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags)
>
> checksyscalls.sh needs to depend on generated/asm-offsets.h, otherwise a
> parallel build will fail.
>
true.

This:

diff --git a/Kbuild b/Kbuild
index 1a2eb32..4caab4f 100644
--- a/Kbuild
+++ b/Kbuild
@@ -94,7 +94,7 @@ targets += missing-syscalls
 quiet_cmd_syscalls = CALL    $<
       cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags)

-missing-syscalls: scripts/checksyscalls.sh FORCE
+missing-syscalls: scripts/checksyscalls.sh $(offsets-file) FORCE
        $(call cmd,syscalls)

 # Keep these two files during make clean


should do the job.

 - Arnaud
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/