linux-kernel - Re: [PATCH RESEND] block: Don't check QUEUE_FLAG_SAME_COMP in __blk_complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E71E15F.1050507@fusionio.com>
Date:	Thu, 15 Sep 2011 13:28:31 +0200
From:	Jens Axboe <jaxboe@...ionio.com>
To:	Christoph Hellwig <hch@...radead.org>
CC:	Tao Ma <tm@....ma>, Shaohua Li <shli@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] block: Don't check QUEUE_FLAG_SAME_COMP in __blk_complete_request.

On 2011-09-15 13:17, Christoph Hellwig wrote:
> On Thu, Sep 15, 2011 at 10:16:02AM +0800, Tao Ma wrote:
>>> why not delete bio_set_completion_cpu()?
>> Not sure. It is added in commit c7c22e4d from the very beginning, and in
>> the commit log Jens described it as:
>> A bio helper (bio_set_completion_cpu()) is also added, so that queuers
>> can ask for completion on that specific CPU. Maybe it is obsolete.
>> Anyway, I am fine to generate a patch to remove it if you prefer.
>>> 1. nobody uses it in my search
>> yes, but it may be designed for someone to use it. The same goes with
>> BIO_CPU_AFFINE.
> 
> This code is unused, and from the all the discussions lately pretty
> obviously broken.  The only thing keeping it serves is creating more
> confusion and possibly more bugs.

We can kill bio_set_completion_cpu(). I'm fine with leaving cpu control
to the request based drivers, they are the only ones that can toggle the
setting anyway.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/