linux-kernel - Re: [PATCH/RFC] parport_pc: remove ancient, overeager quirk that disables EPP support on many chipsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110915133555.GB16636@kroah.com>
Date:	Thu, 15 Sep 2011 15:35:55 +0200
From:	Greg KH <greg@...ah.com>
To:	Leopold Palomo-Avellaneda <leo@...xarxa.net>
Cc:	linux-kernel@...r.kernel.org, Adam Baker <linux@...er-net.org.uk>,
	linux-parport@...ts.infradead.org, 630593@...s.debian.org,
	Nicos Gollan <gollan@...ormatik.uni-kl.de>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Alexander Gordeev <lasaine@....cs.msu.su>,
	Jonathan Nieder <jrnieder@...il.com>
Subject: Re: [PATCH/RFC] parport_pc: remove ancient, overeager quirk that
 disables EPP support on many chipsets

On Thu, Sep 15, 2011 at 02:41:14PM +0200, Leopold Palomo-Avellaneda wrote:
> Hi again,
> 
> sorry for the noise and my mistake. The patch...
> 
> there's a bug in the parport module that have been reported (in another 
> places) some time ago [1]. Also, this bug was reported at Redhat [2], but 
> nobody follow the report and it was closed.
> 
> As Adam Baker said [1] :
> 
> <quote>
> A long time ago (~ 10 years), Intel produced a chipset that 
> included broken EPP support. The Linux parport driver was written to detect 
> such a chipset and disable EPP support on it. Unfortunately the test that was 
> written gives false positives for many current chipsets and no-one seems to 
> know exactly what the problem hardware was, let alone have a sample of it to 
> see if a better test can be written. After such a long time it is probably 
> appropriate to just remove the test (on average it does more harm than good) 
> however you are correct in asserting the driver is unmaintained so no-one is 
> bothering to fix it.
> </quote>
> 
> I have applied the patch to the standard debian kernel and vanilla kernels and 
> runs perfectly. The patch simply erases a check. Applied to some Dell 
> hardware, now the EPP mode is detected and, after some initial tests it's 
> working.
> 
> Please, apply the patch.
> 
> Best regards,
> 
> Leo
> 
> [1] http://lists.infradead.org/pipermail/linux-parport/2008-March/000628.html
> [2] https://bugzilla.redhat.com/show_bug.cgi?id=284471
> 
> 
> Signed-off-by: Adam Baker <linux at baker-net.org.uk>

You can not add someone else's signed-off-by: line to a patch, please go
re-read Documentation/SubmittingPatches as to why.

And did Adam originally write this patch?  Or did you?  If Adam, please
set the authorship information properly.

Oh, and please spell out email addresses properly in signed-off-by
lines, it doesn't hide anything when you do that :)

Third time's a charm?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/