linux-kernel - Re: [PATCH v2] OMAP3: powerdomains: Match silicon revision to select the correct "core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110915002719.GB30941@atomide.com>
Date:	Wed, 14 Sep 2011 17:27:19 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	"Koyamangalath, Abhilash" <abhilash.kv@...com>
Cc:	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] OMAP3: powerdomains: Match silicon revision to
 select the correct "core_pwrdm" definition

* Koyamangalath, Abhilash <abhilash.kv@...com> [110812 00:12]:
> Hi 
> 
> > @@ -58,6 +59,24 @@ static struct powerdomain *_pwrdm_lookup(const char *name)
> > 
> >         list_for_each_entry(temp_pwrdm, &pwrdm_list, node) {
> >                 if (!strcmp(name, temp_pwrdm->name)) {
> > +                       if (!strcmp(name, "core_pwrdm") && cpu_is_omap3630()) {
> > +                               if (omap_rev() > OMAP3630_REV_ES1_0) {
> > +                                       /*
> > +                                        * match omap_chip info for OMAP3630
> > +                                        * Rev ES1.1, ES1.2 or higher
> > +                                        */
> > +                                       if (!(temp_pwrdm->omap_chip.oc
> > +                                               & CHIP_GE_OMAP3630ES1_1))
> > +                                               continue;
> > +                               } else {
> > +                                       /* match omap_chip info for OMAP3630
> > +                                        * Rev ES1.0
> > +                                        */
> > +                                       if (!(temp_pwrdm->omap_chip.oc
> > +                                                & CHIP_IS_OMAP3630ES1))
> > +                                               continue;
> > +                               }
> > +                       }
> >                         pwrdm = temp_pwrdm;
> >                         break;
> >                 }
>
> Any comments ?

Can you please check if this is still needed after Paul's
CHIP_IS removal patches? You can find them at:

git://git.pwsan.com/linux-2.6 omap_chip_remove_cleanup_3.2

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/