linux-kernel - Re: [PATCH] mfd: Combine MFD_SUPPORT and MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110915171634.GD3523@ponder.secretlab.ca>
Date:	Thu, 15 Sep 2011 11:16:34 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Luciano Coelho <coelho@...com>
Cc:	Randy Dunlap <rdunlap@...otime.net>, matti.j.aaltonen@...ia.com,
	johannes@...solutions.net, linux-kernel@...r.kernel.org,
	sameo@...ux.intel.com, mchehab@...radead.org,
	linux-media@...r.kernel.org, linux-omap@...r.kernel.org,
	Jean Delvare <khali@...ux-fr.org>,
	Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH] mfd: Combine MFD_SUPPORT and MFD_CORE

On Mon, Aug 29, 2011 at 09:41:47PM +0300, Luciano Coelho wrote:
> ---
> @@ -417,7 +417,6 @@ config GPIO_TIMBERDALE
>  config GPIO_RDC321X
>  	tristate "RDC R-321x GPIO support"
>  	depends on PCI
> -	select MFD_SUPPORT
>  	select MFD_CORE
>  	select MFD_RDC321X
>  	help
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 21574bd..1836cdf 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -2,10 +2,9 @@
>  # Multifunction miscellaneous devices
>  #
>  
> -menuconfig MFD_SUPPORT
> -	bool "Multifunction device drivers"
> +menuconfig MFD_CORE
> +	tristate "Multifunction device drivers"
>  	depends on HAS_IOMEM
> -	default y

Looks like there is a bug here.  Kconfig symbols with dependencies
(HAS_IOMEM) must not ever be selected by other symbols because Kconfig
doesn't implement a way to resolve them.  This patch means that every
"select MFD_CORE" just assumes that HAS_IOMEM is also selected.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/