linux-kernel - Re: [PATCH 06/20] Staging: hv: util: Properly handle util services in the util driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110915200853.GJ3789@shale.localdomain>
Date:	Thu, 15 Sep 2011 23:08:53 +0300
From:	Dan Carpenter <error27@...il.com>
To:	"K. Y. Srinivasan" <kys@...rosoft.com>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org, virtualization@...ts.osdl.org,
	Haiyang Zhang <haiyangz@...rosoft.com>
Subject: Re: [PATCH 06/20] Staging: hv: util: Properly handle util services
 in the util driver

On Tue, Sep 13, 2011 at 10:59:42AM -0700, K. Y. Srinivasan wrote:
> @@ -403,31 +384,13 @@ static void vmbus_process_offer(struct work_struct *work)
>  		spin_unlock_irqrestore(&vmbus_connection.channel_lock, flags);
>  
>  		free_channel(newchannel);
> -	} else {
> +	} else
>  		/*
>  		 * This state is used to indicate a successful open
>  		 * so that when we do close the channel normally, we
>  		 * can cleanup properly
>  		 */
>  		newchannel->state = CHANNEL_OPEN_STATE;

It's not worth resending, but this should have kept the curly braces
for two style reasons.
1) If one side of the if else pair has braces the other side gets
braces too.
2) If it's more than one line, it gets braces even if it's not needed
for semantic reasons.

Sorry to email you these pedantic things, but if I don't then my OCD 
acts up and I feel all itchy for hours.  Also you have a similar
thing below as well.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/