linux-kernel - Re: [PATCH 07/27] Initconst section fixes for POWERPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110915214308.GA779@elie>
Date:	Thu, 15 Sep 2011 16:43:08 -0500
From:	Jonathan Nieder <jrnieder@...il.com>
To:	Andi Kleen <ak@...ux.intel.com>
Cc:	Josh Boyer <jwboyer@...il.com>, Andi Kleen <andi@...stfloor.org>,
	linux-kernel@...r.kernel.org, benh@...nel.crashing.org
Subject: Re: [PATCH 07/27] Initconst section fixes for POWERPC

On Thu, Sep 15, 2011 at 01:48:09PM -0700, Andi Kleen wrote:
> On 9/15/2011 1:45 PM, Josh Boyer wrote:
>> On Thu, Sep 15, 2011 at 4:09 PM, Andi Kleen<andi@...stfloor.org>  wrote:

>>> From: Andi Kleen<ak@...ux.intel.com>
>>
>> What's the problem again?
>
> It's wrong. For more details see 0/*

Doesn't that mean that people using "git log", perhaps trying to debug
fallout from one of the patches (even if it's as small as making
context not match on some later patch), would have no idea what's
going on?  The cover letter says:

> This is a global tree sweep to fix up initconst section problems.
>
> Any variable const in initdata must be marked __initconst, not initdata.
> const __read_mostly is not allowed.
>
> Otherwise the global sections can get a read only marking and in some
> circumstances the compiler/and or the linker will detect conflicts.
>
> This patchkit aims to fix it up everywhere.

Which seems more sensible.  Since this is going through Linus's tree,
it might (or might not) make sense to combine the patches and describe
the effect once.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/