[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1316156255-19509-1-git-send-email-julia@diku.dk>
Date: Fri, 16 Sep 2011 08:57:32 +0200
From: Julia Lawall <julia@...u.dk>
To: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Cc: kernel-janitors@...r.kernel.org,
Ian Campbell <ian.campbell@...rix.com>,
Jan Beulich <jbeulich@...ell.com>, linux-kernel@...r.kernel.org
Subject: [PATCH 1/4] drivers/block/xen-blkback/blkback.c: take size of pointed value, not pointer
From: Julia Lawall <julia@...u.dk>
Sizeof a pointer-typed expression returns the size of the pointer, not that
of the pointed data.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression *e;
type T;
identifier f;
@@
f(...,(T)e,...,
-sizeof(e)
+sizeof(*e)
,...)
// </smpl>
Signed-off-by: Julia Lawall <julia@...u.dk>
---
drivers/block/xen-blkback/blkback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -790,7 +790,7 @@ static int __init xen_blkif_init(void)
if (rc)
goto failed_init;
- memset(blkbk->pending_reqs, 0, sizeof(blkbk->pending_reqs));
+ memset(blkbk->pending_reqs, 0, sizeof(*blkbk->pending_reqs));
INIT_LIST_HEAD(&blkbk->pending_free);
spin_lock_init(&blkbk->pending_free_lock);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists