linux-kernel - Re: [PATCH/RFC] parport_pc: remove ancient, overeager quirk that disables EPP support on many chipsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 16 Sep 2011 12:39:40 +0200
From:	"Leopold Palomo-Avellaneda" <leo@...xarxa.net>
To:	Bastien ROUCARIES <roucaries.bastien@...il.com>
Cc:	linux-kernel@...r.kernel.org, Adam Baker <linux@...er-net.org.uk>,
	linux-parport@...ts.infradead.org, 630593@...s.debian.org,
	Nicos Gollan <gollan@...ormatik.uni-kl.de>,
	Greg KH <greg@...ah.com>, Alan Cox <alan@...rguk.ukuu.org.uk>,
	Alexander Gordeev <lasaine@....cs.msu.su>,
	Jonathan Nieder <jrnieder@...il.com>
Subject: Re: [PATCH/RFC] parport_pc: remove ancient, overeager quirk that disables EPP support on many chipsets

A Dijous, 15 de setembre de 2011, Bastien ROUCARIES va escriure:
> On Thu, Sep 15, 2011 at 3:41 PM, Bastien ROUCARIES
> <roucaries.bastien@...il.com> wrote:
> > On Thu, Sep 15, 2011 at 2:41 PM, Leopold Palomo-Avellaneda
> > <leo@...xarxa.net> wrote:
> >> Hi again,
> >>
> >> sorry for the noise and my mistake. The patch...
> >>
> >> there's a bug in the parport module that have been reported (in another
> >> places) some time ago [1]. Also, this bug was reported at Redhat [2], but
> >> nobody follow the report and it was closed.
> 
> Moreover they are more detail about this bug here you should contact
> davbid campell
> 
> http://lists.infradead.org/pipermail/linux-parport/2004-March/000048.html

I think that this is a good approach, but it seems that this patch go to 
nowhere.... also solves another question of timeouts.

Leo



> Bastien
> 
> >> As Adam Baker said [1] :
> >>
> >> <quote>
> >> A long time ago (~ 10 years), Intel produced a chipset that
> >
> > Why not check dmi years for this test and do the test only for board
> > before 2000 ? Better safe than sorry
> >
> > Bastien
> >
> >
> >
> >> included broken EPP support. The Linux parport driver was written to 
detect
> >> such a chipset and disable EPP support on it. Unfortunately the test that 
was
> >> written gives false positives for many current chipsets and no-one seems 
to
> >> know exactly what the problem hardware was, let alone have a sample of it 
to
> >> see if a better test can be written. After such a long time it is 
probably
> >> appropriate to just remove the test (on average it does more harm than 
good)
> >> however you are correct in asserting the driver is unmaintained so no-one 
is
> >> bothering to fix it.
> >> </quote>
> >>
> >> I have applied the patch to the standard debian kernel and vanilla 
kernels and
> >> runs perfectly. The patch simply erases a check. Applied to some Dell
> >> hardware, now the EPP mode is detected and, after some initial tests it's
> >> working.
> >>
> >> Please, apply the patch.
> >>
> >> Best regards,
> >>
> >> Leo
> >>
> >> [1] http://lists.infradead.org/pipermail/linux-parport/2008-
March/000628.html
> >> [2] https://bugzilla.redhat.com/show_bug.cgi?id=284471
> >>
> >>
> >> Signed-off-by: Adam Baker <linux at baker-net.org.uk>
> >> Signed-off-by: Leopold Palomo-Avellaneda <leo@...xarxa.net>
> >>
> >>
> >> ---
> >>
> >
> 


-- 
--
Linux User 152692
Catalonia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/