linux-kernel - Re: [PATCH] sysfs: add per pci device msi[x] irq listing (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110916132319.GC8973@suse.de>
Date:	Fri, 16 Sep 2011 15:23:19 +0200
From:	Greg KH <gregkh@...e.de>
To:	Neil Horman <nhorman@...driver.com>
Cc:	linux-kernel@...r.kernel.org,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH] sysfs: add per pci device msi[x] irq listing (v2)

On Fri, Sep 16, 2011 at 06:57:16AM -0400, Neil Horman wrote:
> On Fri, Sep 16, 2011 at 10:36:46AM +0200, Greg KH wrote:
> > On Thu, Sep 15, 2011 at 04:08:38PM -0400, Neil Horman wrote:
> > > +static struct kobj_type msi_irq_ktype = {
> > > +	.sysfs_ops = &msi_irq_sysfs_ops,
> > > +	.default_attrs = msi_irq_default_attrs,
> > > +};
> > 
> > You still haven't successfully removed the kobject associated with this
> > kobj_type.  Otherwise you would have seen the error messages in the
> > kernel log and fixed up what it told you to fix.
> > 
> > Please do so.
> > 
> Well, I'm not using kobject_del, you're right, I'm just using a kobject_put, and
> I swear I'm not getting any error messages about it:

Then you really are not ever freeing that kobject, so there's a
reference counting bug in your code which you need to fix.

You will notice the real problem once you try to finally release that
kobject, trust me :)

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/